Signals for the external acquisition of an api_access_info #2051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I would like to introduce two new signals, to enable the api login process through an
external_service
.Signal1:
application::login_attempt
emitted at the end ofapplication_impl::new_connection
.Signal2:
login_api::api_access_info_external
emitted at the beginning oflogin_api::login
.Logic:
Alternatively this could be done with the first signal alone, but then the service would have to implement the login logic, which I tried to avoid here.
What do you think? Would this be a way to implement that? Open for any discussion.