This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Switch to use secp256k1 native bindings for signing #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,13 @@ var BufferUtil = require('../util/buffer'); | |||
| var _ = require('lodash'); | |||
| var $ = require('../util/preconditions'); | |||
|
|
|||
| var secp256k1 = null; | |||
| try { | |||
| secp256k1 = require('secp' + '256k1'); | |||
There was a problem hiding this comment.
secp256k1 = require('secp256k1/bindings') should work also
There was a problem hiding this comment.
Just tried running this with this build: https://travis-ci.org/bitpay/bitcore-lib/builds/160276007 and there still seems to be an issue with browserify.
matiu
reviewed
Oct 26, 2017
| @@ -124,7 +124,7 @@ describe('ECDSA', function() { | |||
| }); | |||
|
|
|||
| describe('#toPublicKey', function() { | |||
| it('should calculate the correct public key', function() { | |||
| it.skip('should calculate the correct public key', function() { | |||
There was a problem hiding this comment.
I can't remember if the test wasn't passing because it was a case that wasn't able to test, or if there was an issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to use libsecp256k1 for transactions signing, with secp256k1 as an optional dependency.