Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estela-web: Automatically try to add arguments, env vars, and tags written in creation forms #226

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raymond1242
Copy link
Contributor

@raymond1242 raymond1242 commented Aug 27, 2023

Description

estela-web: Automatically try to add arguments, env vars, and tags written in creation forms

Issue

* Github Issue ID.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have made corresponding changes to the documentation.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@raymond1242 raymond1242 added the bug Something isn't working label Aug 27, 2023
@raymond1242 raymond1242 self-assigned this Aug 27, 2023
Copy link
Member

@mgonnav mgonnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymond1242 I have added a change refactoring some of the code. We still need to add this functionality to the clone modals.

Also, ensure that we verify both cases correctly when the name is present but the value isn't and vice-versa. I fixed it for the create modals because if I had an argument/env var name: it would raise an error but :value would create the job without verifying this is not a valid argument/env var.

@raymond1242
Copy link
Contributor Author

@raymond1242 I have added a change refactoring some of the code. We still need to add this functionality to the clone modals.

Also, ensure that we verify both cases correctly when the name is present but the value isn't and vice-versa. I fixed it for the create modals because if I had an argument/env var name: it would raise an error but :value would create the job without verifying this is not a valid argument/env var.

Done @mgonnav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants