UI Fixes #795
Open
UI Fixes #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akshay8551
commented
Jan 24, 2025
akshay8551
commented
- Invalid Bitcoin address error on scanning a receive invoice #755
- UI issue in the app #773
- Wallet Backup text changes #701
- We need to show Ticker in Coins detail screen #713
- View unspent UTXOs needs to be improved #694
- Learn more content for all wallet modes #678
cakesoft-shashank
requested changes
Jan 24, 2025
| <ScreenContainer> | ||
| <AppHeader title={onBoarding.mainnetAndLightning} /> | ||
| <ScrollView style={styles.wrapper}> | ||
| <View> |
There was a problem hiding this comment.
is View required here?
There was a problem hiding this comment.
Other parts of the component structure use a to wrap content, and I’d like to maintain a consistent layout pattern. Even though the current styling is minimal, the ensures we can easily isolate styles or behaviors specific to this block in the future.
| onPressSend={onPressSend} | ||
| onPressRecieve={onPressRecieve} | ||
| onPressBuy={onPressBuy} | ||
| sendCtaWidth={wp(150)} |
There was a problem hiding this comment.
how this 150 is decided?
There was a problem hiding this comment.
The width of 150 was chosen to provide better spacing and ensure the buttons are easy to tap, while still being responsive with wp(). It ensures consistency across devices, even though the XD design suggests 140.
…nto reusable component
…d also added props type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.