Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #663
Testnets are tough right now, testnet4 is another option we should give people to help them build with bdk-ffi.
@ValuedMammal added this same thing it in bdk, which was included in the bdk_wallet 1.1 release
We should have it in bdk-ffi as well.
Currently we rely on bitcoin-ffi for our
Network
type so I think our only option if we use bitcoin-ffi is to update bitcoin-ffi and then pull that new version of bitcoin-ffi with testnet4 into bdk-ffi.Notes to the reviewers
Points to a PR branch in bitcoin-ffi.
Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: