Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-915) adjust to new web-backend detailed errors #82

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jul 26, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided: CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Because of changes in web-backend (bitcoin-sv/spv-wallet-web-backend#83) I had to make some adjustments and - by the way - some simplification of how we handle and show error messages.

@chris-4chain chris-4chain requested a review from a team as a code owner July 26, 2024 11:51
Copy link

github-actions bot commented Jul 26, 2024

Manual Tests

πŸ’š Manual testing by @mpi4chain resulted in success.

@mpi4chain mpi4chain added the tested PR was tested by a team member label Aug 27, 2024
@chris-4chain chris-4chain merged commit 6912471 into main Aug 27, 2024
3 checks passed
@chris-4chain chris-4chain deleted the feat-915-adjust-errors branch August 27, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants