Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(223): replace router with gin #74

Merged
merged 8 commits into from
Feb 26, 2024
Merged

feat(223): replace router with gin #74

merged 8 commits into from
Feb 26, 2024

Conversation

pawellewandowski98
Copy link
Contributor

@pawellewandowski98 pawellewandowski98 commented Feb 16, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Description

  • Replaced nrhttprouter with gin

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @wregulski resulted in success.

@pawellewandowski98 pawellewandowski98 mentioned this pull request Feb 16, 2024
Merged
7 tasks
arkadiuszos4chain
arkadiuszos4chain reviewed Feb 22, 2024
View reviewed changes
server/base.go Outdated Show resolved Hide resolved
arkadiuszos4chain
arkadiuszos4chain reviewed Feb 22, 2024
View reviewed changes
server/base.go Outdated Show resolved Hide resolved
arkadiuszos4chain
arkadiuszos4chain reviewed Feb 22, 2024
View reviewed changes
server/router.go Outdated Show resolved Hide resolved
arkadiuszos4chain
arkadiuszos4chain reviewed Feb 22, 2024
View reviewed changes
server/error.go Outdated Show resolved Hide resolved
@wregulski wregulski added the tested PR was tested by a team member label Feb 26, 2024
@wregulski wregulski merged commit 9d9f3e7 into main Feb 26, 2024
3 checks passed
@wregulski wregulski deleted the feat-223-replace-router-with-gin branch February 26, 2024 09:39
@bsvassociation-bot bsvassociation-bot mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawellewandowski98 @dorzepowski @arkadiuszos4chain @wregulski