Merge pull request #97 from bitcoin-sv/feat-spv-827-Switch-Contacts-c…

…apability-from-BRFCTemporaryPike-to-BRFCPike.invite

Feat (spv-827) switch contacts capability from brfc temporary pike to brfc pike.invite

brfc_definintions.go

@@ -18,12 +18,9 @@ const (
 	BRFCSFPBuildAction                 = "189e32d93d28"       // more info: https://docs.moneybutton.com/docs/sfp/paymail-09-sfp-build.html
 	BRFCVerifyPublicKeyOwner           = "a9f510c16bde"       // more info: http://bsvalias.org/05-verify-public-key-owner.html
 	BRFCBeefTransaction                = "5c55a7fdb7bb"       // more info: https://bsv.brc.dev/payments/0070
-
-	BRFCTemporaryPike = "8c4ed5ef8ace" // Temporary BRFC ID for PIKE
-
-	BRFCPike        = "935478af7bf2"
-	BRFCPikeInvite  = "invite"
-	BRFCPikeOutputs = "outputs"
+	BRFCPike                           = "8c4ed5ef8ace"
+	BRFCPikeInvite                     = "invite"
+	BRFCPikeOutputs                    = "outputs"
 )
 
 // BRFCKnownSpecifications is a running list of all known BRFC specifications

capabilities_test.go

@@ -270,7 +270,7 @@ func mockCapabilitiesWithPIKE(statusCode int) {
 					"6745385c3fc0": false,
 					"pki": "https://examples.com/{alias}@{domain.tld}/id",
 					"paymentDestination": "https://examples.com/{alias}@{domain.tld}/payment-destination",
-					"935478af7bf2": {
+					"8c4ed5ef8ace": {
 						"invite": "https://examples.com/v1/bsvalias/contact/invite/{alias}@{domain.tld}",
 						"outputs": "https://examples.com/v1/bsvalias/pike/outputs/{alias}@{domain.tld}"
 					}

server/capabilities.go

@@ -2,10 +2,11 @@ package server
 
 import (
 	"fmt"
-	"github.com/gin-gonic/gin"
 	"net/http"
 	"strings"
 
+	"github.com/gin-gonic/gin"
+
 	"github.com/bitcoin-sv/go-paymail"
 )
 
@@ -81,15 +82,6 @@ func (c *Configuration) SetBeefCapabilities() {
 }
 
 func (c *Configuration) SetPikeContactCapabilities() {
-	_addCapabilities(c.callableCapabilities,
-		CallableCapabilitiesMap{
-			paymail.BRFCTemporaryPike: CallableCapability{
-				Path:    fmt.Sprintf("/pike/%s", PaymailAddressTemplate),
-				Method:  http.MethodPost,
-				Handler: c.pikeNewContact,
-			},
-		},
-	)
 	_addNestedCapabilities(c.nestedCapabilities,
 		NestedCapabilitiesMap{
 			paymail.BRFCPike: CallableCapabilitiesMap{

server/config_test.go

@@ -4,9 +4,10 @@ import (
 	"testing"
 	"time"
 
-	"github.com/bitcoin-sv/go-paymail"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/bitcoin-sv/go-paymail"
 )
 
 // testConfig loads a basic test configuration
@@ -490,7 +491,7 @@ func TestNewConfig(t *testing.T) {
 		)
 		require.NoError(t, err)
 		require.NotNil(t, c)
-		assert.Equal(t, 7, len(c.callableCapabilities))
+		assert.Equal(t, 6, len(c.callableCapabilities))
 		assert.Equal(t, 1, len(c.nestedCapabilities))
 	})
 
@@ -526,7 +527,7 @@ func TestNewConfig(t *testing.T) {
 		)
 		require.NoError(t, err)
 		require.NotNil(t, c)
-		assert.Equal(t, 7, len(c.callableCapabilities))
+		assert.Equal(t, 6, len(c.callableCapabilities))
 		assert.Equal(t, 1, len(c.nestedCapabilities))
 	})