Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get unmined ancestors #646

Closed
wants to merge 7 commits into from
Closed

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Nov 13, 2024

Description of Changes

The recursive search for unmined ancestors lead to sometimes long response times when submitting requests with the cumulative fee validation. The bitcoin node function GetMempoolAncestors offers an easy to use and fast alternative to return all unmined ancestors to a transaction.

  • Instead of recursively searching for unmined ancestors, use the node function GetMempoolAncestors from bitcoin node
  • Node client with integration tests
  • Search misspellings and fix

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@boecklim boecklim changed the title Fix/get unmined ancestors fix: get unmined ancestors Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

@boecklim
Copy link
Collaborator Author

Will be replaced by #647 and other follow-up PRs

@boecklim boecklim closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant