forked from Ivy-Apps/ivy-wallet
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR template - removed 'main' branch checkbox, in code view: deleted b…
…lank lines, clarified comments (Ivy-Apps#3336)
- Loading branch information
Showing
1 changed file
with
8 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,71 +1,39 @@ | ||
| ## Pull request (PR) checklist | ||
|
|
||
| Please check if your pull request fulfills the following requirements: | ||
|
|
||
| <!-- 💡 Tip: Tick checkboxes like this: [x] --> | ||
|
|
||
| - [ ] The PR is submitted to the `main` branch. | ||
| <!--💡 Tip: Tick checkboxes like this: [x] 💡--> | ||
| - [ ] I've read the [Contribution Guidelines](https://github.com/Ivy-Apps/ivy-wallet/blob/main/CONTRIBUTING.md) and my PR doesn't break the rules. | ||
| - [ ] I've read and understand the [Developer Guidelines](https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/Guidelines.md). | ||
| - [ ] I confirm that I've run the code locally and everything works as expected. | ||
| - [ ] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed). | ||
| - [ ] 🎬 I've attached a **screen recording** of using the new code to the next paragraph (if applicable). | ||
|
|
||
|
|
||
| ## Screen recording of interacting with your changes: | ||
|
|
||
| <!-- 💡 Tip: Drag & drop the video here. --> | ||
|
|
||
|
|
||
| <!--💡 Tip: Drag & drop the video here. 💡--> | ||
|
|
||
| ## What's changed? | ||
| Describe with a few bullets **what's new:** | ||
|
|
||
| <!-- 💡 Tip: After each more important point leave one line empty and show your changes in markdown table with screenshots or screen recordings replacing {media}. In the end, it should look like this: | ||
| <!--💡 Tip: After each more important point leave one line empty and show your changes in markdown table with screenshots or screen recordings replacing {media}. In the end, it should look like this: 💡--> | ||
| - I've fixed... | ||
|
|
||
| Before|After | ||
| -------|------- | ||
| ---------|--------- | ||
| {media}|{media} | ||
| {media}|{media} | ||
| --> | ||
|
|
||
|
|
||
| - ... | ||
|
|
||
|
|
||
| - ... | ||
|
|
||
|
|
||
| ## Risk factors | ||
|
|
||
| **What may go wrong if we merge your PR?** | ||
|
|
||
| - ... | ||
| - ... | ||
|
|
||
| **In what cases won't your code work?** | ||
|
|
||
| - ... | ||
| - ... | ||
|
|
||
|
|
||
| ## Does this PR close any GitHub issues? | ||
|
|
||
| - Closes #{ISSUE_NUMBER} | ||
| <!-- For example: | ||
| - Closes #123 | ||
| --> | ||
|
|
||
| <!-- 💡 Tip: Replace {ISSUE_NUMBER} with the number of Ivy Wallet ISSUE (https://github.com/Ivy-Apps/ivy-wallet/issues) (❗NOT PR❗) which this pull request fixes. If done correctly, you'll see the issue title linked on PR preview. --> | ||
|
|
||
| <!-- 💡 Tip: Multiple issues: | ||
| <!--❗For example: - Closes #123 ❗--> | ||
| <!--💡 Tip: Replace {ISSUE_NUMBER} with the number of Ivy Wallet ISSUE (https://github.com/Ivy-Apps/ivy-wallet/issues)(❗NOT PR❗) which this pull request fixes. If done correctly, you'll see the issue title linked on PR preview. 💡--> | ||
| <!--💡 Tip: Multiple issues: | ||
| - Closes #{ISSUE_NUMBER_1}, closes #{ISSUE_NUMBER_2}, closes #{ISSUE_NUMBER_3} | ||
| --> | ||
|
|
||
|
|
||
| 💡--> | ||
| ## Troubleshooting CI failures ❌ | ||
|
|
||
| Pull request checks failing? Read our [CI Troubleshooting guide](https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md). |