Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retry-staleness dynamics and error handling for locks #9

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

NeuralFlux
Copy link
Contributor

@NeuralFlux NeuralFlux commented Nov 14, 2024

linked to biothings/biothings_explorer#896

  • Increased staleness time to be higher than retry timeout just in case locks aren't released after they turn stale
  • Throw error if lock cannot be obtained
  • Try releasing locks one by one and fail gracefully

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 50.88%. Comparing base (55c6640) to head (489432a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/misc.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   51.43%   50.88%   -0.55%     
==========================================
  Files           5        5              
  Lines         278      281       +3     
  Branches       41       41              
==========================================
  Hits          143      143              
- Misses        130      133       +3     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tokebe tokebe merged commit 038bf8c into main Nov 14, 2024
2 of 4 checks passed
@tokebe tokebe deleted the fix-896-bte branch November 14, 2024 17:57
@tokebe tokebe restored the fix-896-bte branch November 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants