-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust SmartAPI yaml, x-bte annotation for Biolink/Monarch API migration #774
Comments
Jackson @tokebe noticed some increased request failures, so I updated the SmartAPI yaml / registration to use the v2 server url (see lab Slack convo). We'll monitor to see if there's any improvement.
Potential queries for directly comparing v1 and v2:
|
Hi @colleenXu, We're shutting down api.monarchinitiative.org, and our new production api is served from api-v3.monarchinitiative.org. As a transition to let people know that api.monarchinitiative.org is going away, we're planning to put a message up on that host but continue to make it available on another hostname - we picked api-v2 for that, but unfortunately it does make total sense that it would appear to be the replacement. The v3 api format is different, the good news is that we should be better able to address performance problems (within limits). The v3 api is served from the new core graph, which is built on the biolink data model with new ingests. Side note, I'm actually not seeing any direct gene expression for spinal cord or pancreas in the new graph: I created an issue for specifying the subject/object taxon, and a second issue to look at our gene expression ingests. |
[EDITED w/ updated info] Latest info on the Biolink/monarch migration to v3 https://api-v3.monarchinitiative.org/v3/docs#/:
So the next steps are:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
NotesOn writing SmartAPI yaml
Querying the v3 API
(@kevinschaper and any others working on the Monarch API may find this post interesting) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
see https://github.com/biothings/biothings_explorer/issues/774\#issuecomment-1923328949 for reasons to use association endpoint now covering all the operations written for old api (that are still available)
Jackson @tokebe: I changed the x-bte annotation to use the
So now the post-processing is different, but hopefully simpler... STILL NEED:
Publication info from old comment
B. PublicationsFor now: within an item/hit, only keep elements in the I've noticed other kinds of elements like:
Also, there's a DON'T NEED:
|
[EDITED to add info on what we learned / addressed while working on the API post-processing] UpdateThe basic set of updates is done:
Working onJackson @tokebe discussed the following, and they're going to try it out: doing post-processing on the Example
A.
B.
Putting this together: create a new, custom field with the TRAPI sources array
implementation notes
Example showing this
Send the following TRAPI query to Monarch API only, through BTE:
BTE should make the following requests:
Then bundle these into two Edges: 1 for biogrid and 1 for string
A similar example is TTN (HGNC:12403 / NCBIGene:7273) |
Knowledge source infores IDs used by this resourceFrom Kevin Schaper (Translator Slack link)
current possible knowledge source combos on edges
|
This is now ready for deployment!
PRs for push to Prod:
Once these are fully deployed to Prod, we can update the registered yaml (PR) and start the process of removing the override... |
Notes
Stuff to follow up onShort-termEDIT, DONE: Sierra and Kevin confirmed 2/28 that it's fine to change infores, and we could deprecate
Example of wonky behavior
The edge source info would look like this:
Longer-term?EDIT: moving to separate issues
click to see MetaEdges
|
I've confirmed that the changes have been deployed to BTE Prod. So I've:
How I tested
We can tell that BTE is using the new v3 Monarch API by doing a test query for the POST to Monarch-API-only, thru BTE: https://bte.transltr.io/v1/smartapi/d22b657426375a5295e7da8a303b9893/query
Should get this edge in the response, showing the
BUT before closing this, I'd like to discuss "stuff to follow up on" with Jackson @tokebe first...(open new issues?) |
Discussed the "stuff to follow up on" with Jackson and Sierra/Kevin (see edited post). I'll open new issues, but we're ready to close this one |
EDIT: see below for update, actually migrating to v3 https://api-v3.monarchinitiative.org/v3/docs#/
We are using Biolink/Monarch API v1, which will soon be shutdown and replaced by v2 http://api-v2.monarchinitiative.org/api.
So we'll want to adjust the SmartAPI yaml using the v2's swagger spec + adjust the x-bte annotation if needed.
What's unclear at the moment:
The text was updated successfully, but these errors were encountered: