update environment, sentry error handling

biothings · Aug 10, 2023 · b8fa1b4 · b8fa1b4
1 parent 1d36e10
commit b8fa1b4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/config/index.js b/src/config/index.js
@@ -101,6 +101,7 @@ module.exports = class Config {
             // of transactions for performance monitoring.
             // We recommend adjusting this value in production
             tracesSampleRate: process.env.EXPRESS_SAMPLE_RATE ? parseFloat(process.env.EXPRESS_SAMPLE_RATE) : 1.0,
+            environment: process.env.INSTANCE_ENV
         });
 
         // RequestHandler creates a separate execution context, so that all

diff --git a/src/controllers/threading/taskHandler.js b/src/controllers/threading/taskHandler.js
@@ -19,6 +19,8 @@ Sentry.init({
       ...Sentry.autoDiscoverNodePerformanceMonitoringIntegrations(),
       new ProfilingIntegration()
     ],
+    environment: process.env.INSTANCE_ENV,
+    debug: true,
     normalizeDepth: 6,
     maxBreadcrumbs: 500,
     // Set tracesSampleRate to 1.0 to capture 100%

diff --git a/src/middlewares/error.js b/src/middlewares/error.js
@@ -19,14 +19,20 @@ class ErrorHandler {
     ) {
       return false;
     }
+    if (error.name === "QueryAborted") {
+      return false;
+    }
     return true;
   }
 
   setRoutes(app) {
     // first pass through sentry
     app.use(Sentry.Handlers.errorHandler({
       shouldHandleError(error) {
-         // Capture all 404 and 500 errors
+        // Do not capture non-server errors
+        if (error.status && error.status < 500) {
+            return false;
+        }
         if (error instanceof swaggerValidation.InputValidationError || error.name === "InputValidationError") {
             return false;
         }
@@ -37,6 +43,9 @@ class ErrorHandler {
         ) {
             return false;
         }
+        if (error.name === "QueryAborted") {
+          return false;
+        }
         return true;
       }
     }));