Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useNamingConvention): preserve capitalization #4955

Merged

Conversation

Conaclos
Copy link
Member

Summary

Fix #4873

The rule now tries to preserve the capitalization if a possible case starts with a capital.

Test Plan

I added a test

@Conaclos Conaclos changed the base branch from main to next January 23, 2025 21:09
@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter L-CSS Language: CSS A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Jan 23, 2025
@Conaclos Conaclos requested review from a team January 23, 2025 21:09
@Conaclos Conaclos changed the title Conaclos/use naming convention preserves capitalization refactor(useNamingConvention): preserve capitalization Jan 23, 2025
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #4955 will not alter performance

Comparing conaclos/useNamingConvention-preserves-capitalization (f6671dc) with next (d400d69)

Summary

✅ 95 untouched benchmarks

@Conaclos Conaclos merged commit 0bf4eaa into next Jan 24, 2025
13 of 14 checks passed
@Conaclos Conaclos deleted the conaclos/useNamingConvention-preserves-capitalization branch January 24, 2025 10:04
unvalley pushed a commit to unvalley/biome that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 useNamingConvention fix breaks code
2 participants