-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting features gait #4
Conversation
I recommend merging the |
@vedran-kasalica what do you recommend here now? |
@Erikpostt I would recommend this, but we can also do that together on Thursday. |
…nson/dbpd-toolbox into extracting_features_gait
…nson/dbpd-toolbox into extracting_features_gait
@vedran-kasalica what do you think of the proposed changes? |
The changes look good! I will finish reviewing the code tomorrow. We will probably merge the PR and then set up some tests based on your Notebooks and start adding more modules to the toolbox. I have some suggestions (e.g., we probably don't need to store the field |
@Erikpostt it was not clear to me what is the content of |
You are right Vedran, this is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I tested the Notebooks locally and they run without issues.
Instead of requesting changes to the PR, I opened an issue (see #8). It would be good to address it soon after merging this PR.
I propose to merge the PR and create new PRs to address the follow-up refactoring.
@kretep once you review the PR, feel free to merge it.
PR contains
imu_preprocessing.py
with added functionality for windowing and feature engineering;Waiting with reviewing (and merging) until
imu_preprocessing.py
;