-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Visualize documentation update #6993
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried making this an indexed image in Gimp and it was 128KB (the original was 370).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way of using some python library instead? I think it is not practical to have GIMP just for this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS I think I used to do it with ImageMagick. It includes a command-line utility convert
.
We were just discussing it with @markotoplak and @ajdapretnar. Perhaps we should abandon indexing altogether because it often visibly degrades the colors. This will increase the size of image files, but if we move all documentation to web (as discussed in another issue), we don't mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamps are too small.
We should also be careful in setting visualizations not to waste space. Here, the window could be decreased in width a bit so that the widget becomes less wide. Also, the height could be possibly made smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked: stamps always used to be so small... But now we have the opportunity to improve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janezd and me decided that we have to fix the stamper and that I should do it.
Issue
Partially resolves #6986.
Description of changes
Includes