Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Calibrated Learner: Prevent in place modification of base learner #6917

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[FIX] Calibrated Learner: Prevent in place modification of base learner #6917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions Orange/widgets/model/owcalibratedlearner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import copy

from Orange.classification import CalibratedLearner, ThresholdLearner, \
NaiveBayesLearner
from Orange.data import Table
Expand Down Expand Up @@ -65,7 +67,6 @@ def set_learner(self, learner):
self.learner = self.model = None

def _set_default_name(self):

if self.base_learner is None:
self.set_default_learner_name("")
else:
Expand All @@ -80,10 +81,6 @@ def calibration_options_changed(self):
self.apply()

def create_learner(self):
class IdentityWrapper(Learner):
def fit_storage(self, data):
return self.base_learner.fit_storage(data)

if self.base_learner is None:
return None
learner = self.base_learner
Expand All @@ -93,10 +90,11 @@ def fit_storage(self, data):
if self.threshold != self.NoThresholdOptimization:
learner = ThresholdLearner(learner,
self.ThresholdMap[self.threshold])
if learner is self.base_learner:
learner = copy.deepcopy(learner)
if self.preprocessors:
if learner is self.base_learner:
learner = IdentityWrapper()
learner.preprocessors = (self.preprocessors, )
assert learner is not self.base_learner
ales-erjavec marked this conversation as resolved.
Show resolved Hide resolved
return learner

def get_learner_parameters(self):
Expand Down
2 changes: 1 addition & 1 deletion Orange/widgets/model/tests/test_owcalibratedlearner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def test_create_learner(self):
widget.calibration = widget.NoCalibration
widget.threshold = widget.NoThresholdOptimization
learner = self.widget.create_learner()
self.assertIs(learner, self.widget.base_learner)
self.assertIsNot(learner, self.widget.base_learner)

widget.calibration = widget.SigmoidCalibration
widget.threshold = widget.OptimizeF1
Expand Down
Loading