Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack: new table instead of transform #6723

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

ajdapretnar
Copy link
Contributor

@ajdapretnar ajdapretnar commented Feb 2, 2024

Issue

Fixes #6665.

Description of changes

Stacking transformed the data to the same data type as the input. However, Timeseries has an inbuilt assert for time variable, which was missing from stacked_data.

Tests will be added to Timeseries add-on.

Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #6723 (83e3705) into master (7bdc8e4) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 83e3705 differs from pull request most recent head 3bb991d. Consider uploading reports for the commit 3bb991d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6723      +/-   ##
==========================================
- Coverage   88.13%   88.13%   -0.01%     
==========================================
  Files         322      322              
  Lines       70577    70577              
==========================================
- Hits        62206    62205       -1     
- Misses       8371     8372       +1     

@ajdapretnar
Copy link
Contributor Author

[note to self] Converted to draft. Add a test creating a dummy Table class, then mocking self.aggregate from stack.py.

@ajdapretnar ajdapretnar marked this pull request as ready for review February 23, 2024 09:22
@ajdapretnar ajdapretnar requested a review from janezd February 23, 2024 09:23
@ajdapretnar
Copy link
Contributor Author

@janezd We went back and forth with Lan on this one. This was the simplest solution we could find.

@janezd janezd merged commit 194572b into biolab:master Feb 23, 2024
18 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacking Widget: "Stack failed with an error" when using Time Slice as Data source
2 participants