Predictions: Output annotated table #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6718 +/- ##
==========================================
- Coverage 88.13% 88.13% -0.01%
==========================================
Files 322 322
Lines 70577 70586 +9
==========================================
+ Hits 62202 62208 +6
- Misses 8375 8378 +3 |
janezd
force-pushed
the
predictions-annotated
branch
from
14c0d52 to
b715ce9
Compare
VesnaT
reviewed
Feb 2, 2024
| or predmodel is not None and predmodel.sortColumn() > 0: | ||
| predictions = predictions[datamodel.mapToSourceRows(...)] | ||
| selected = predictions | ||
| annotated_data = predictions |
There was a problem hiding this comment.
Annotated data is missing the Selected attribute when no rows are selected.
VesnaT
reviewed
Feb 2, 2024
| annotated_data = predictions | ||
| self.Outputs.selected_predictions.send(selected) | ||
| self.Outputs.annotated.send(annotated_data) | ||
|
|
There was a problem hiding this comment.
While at it, you can also remove the redundant new line :)
|
@VesnaT. there was another bug: if the user sorted the table, the output was sorted only when nothing was selected. I fixed all in a separate commit; please squash when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6711.
Description of changes
Add a (potentially lazy) output with annotated predictions.
I haven't made the existing output lazy, although this should be done at some point -- but perhaps as a general change in other widgets as well.
Includes