Implement __eq__ and __hash__ for PCA (and family) #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
pca-eq-2
branch
2 times, most recently
from
5b41873 to
528b0e3
Compare
|
"(...) for PCA", and for other classes derived from Thank you! I disabled these warnings just to be able to normally work on #6614! |
markotoplak
changed the title
markotoplak
changed the title
|
@janezd, I did what I could to make warnings go away. It is not pretty (see the second commit), but for a straightforward implementations the whole |
markotoplak
force-pushed
the
pca-eq-2
branch
from
84bc7ba to
b9489a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are too many warnings when using PCA.
Having worked with this code, I saw that just about everything is wrong with this class hierarchy - it is much too circular. These classes need to be rewritten - at first I though I won't even be able to implement
__eq__and__hash__, but then I somehow remembered the trick in the second commit.I also added a tiny test. I could theoretically test all classes in the chain separately by initializing them manually and call corresponding functions, but am not sure that would make sense. Do I have to?
Includes