-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Feature Constructor: Vectorize when possible #5949
Conversation
b9e2847
to
449bb82
Compare
Codecov Report
@@ Coverage Diff @@
## master #5949 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 315 315
Lines 66906 66920 +14
=======================================
+ Hits 57728 57745 +17
+ Misses 9178 9175 -3 |
449bb82
to
ebd5967
Compare
This works for my limited amount of use cases. |
I was looking at math vs numpy docs and did not see any cases where I would predict conflicts. That does not mean they aren't any. @janezd also raised the question about import everything from |
ebd5967
to
76822b9
Compare
@markotoplak, I checked the functions in As for reporting warnings and errors in expressions: the problem here is that the user can write an expression that cannot be evaluated by numpy, in which case we fall back to per-instance evaluation. To be on the safe side, I'd fall back at any sign of trouble, that is, at any warning or error. When this happen, the execution will be slower (that is: as slow as before this PR) and any errors will be properly reported. |
add7617
to
64d5fc8
Compare
64d5fc8
to
7a2b9e8
Compare
The random functions (gauss, normalvariate, ...) no longer work on per instance basis. Single generated value is used for the whole column (e.g. |
Closed in favor of #5975. |
Issue
Resolves #5911.
Description of changes
np
instead of frommath
when available.cumsum
,cumprod
, which created two-dimensional data instead of a columnIncludes