Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Save File when workflow basedir is an empty string #5459

Merged
merged 2 commits into from
Jun 4, 2021
Merged

[FIX] Save File when workflow basedir is an empty string #5459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d92e4
owsavebase: Fix check for workflow_dir
ales-erjavec May 28, 2021
46e2a98
run: Always use absolute path for 'basedir'
ales-erjavec May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Orange/canvas/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ def main(argv=None):
)
widget_discovery.run(cfg.widgets_entry_points())
model = cfg.workflow_constructor()
model.set_runtime_env("basedir", os.path.dirname(filename))
model.set_runtime_env(
"basedir", os.path.abspath(os.path.dirname(filename))
)
sigprop = model.findChild(signalmanager.SignalManager)
sigprop.pause() # Pause signal propagation during load

Expand Down
2 changes: 1 addition & 1 deletion Orange/widgets/utils/save/owsavebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def _abs_path_from_setting(self):
if os.path.exists(self.stored_path):
self.auto_save = False
return self.stored_path
elif workflow_dir:
elif workflow_dir is not None:
return os.path.normpath(
os.path.join(workflow_dir, self.stored_path))

Expand Down