Customizable plot: no need for QApplication at import #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4941 +/- ##
==========================================
- Coverage 84.24% 84.22% -0.03%
==========================================
Files 283 278 -5
Lines 57873 57043 -830
==========================================
- Hits 48756 48045 -711
+ Misses 9117 8998 -119 |
markotoplak
force-pushed
the
refactor_visual_settings
branch
4 times, most recently
from
47a98f4 to
f276f78
Compare
To set Updater there had to be an active QApplication when Updater was imported, because default font settings were set as class attributes. This led to some segfaults in tests, which also created a QApplication instance. Default font properties were moved to the __init__ of CommonParameterSetter. Also, parameter setters are now encapsulated by corresponding graphs and not mixed into them.
markotoplak
force-pushed
the
refactor_visual_settings
branch
from
f276f78 to
8d587bd
Compare
markotoplak
changed the title
VesnaT
reviewed
Aug 17, 2020
| @@ -273,6 +231,8 @@ def update_axis(axis, **settings): | |||
| } | |||
| } | |||
|
|
|||
| self.initial_settings = {} | |||
There was a problem hiding this comment.
You can use
initial_settings: Dict[str, Dict[str, SettingsType]] = NotImplemented
if you want to keep the old functionality, but I'm fine with any solution.
|
I do not think that Appveyor complaints are connected with this PR. It also crashes similarly in unrelated PRs, see for example https://ci.appveyor.com/project/biolab/orange3-75xll/builds/34706479. |
|
Appveyor is no more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4934. To set Updater there had to be an active QApplication when Updater was imported, because default font settings were set as class attributes. This led to some segfaults in tests, which also created a QApplication instance.
Description of changes
Default font properties were moved to the
__init__of CommonParameterSetter. Also, parameter setters are now encapsulated by corresponding graphs and not mixed into them.Includes