CSV file Import: Backward compatibility #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
csv-import-backward
branch
8 times, most recently
from
2a40b75 to
c2f19fd
Compare
PrimozGodec
force-pushed
the
csv-import-backward
branch
from
c2f19fd to
fe064b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4876 +/- ##
==========================================
- Coverage 84.20% 84.14% -0.06%
==========================================
Files 282 277 -5
Lines 57342 56642 -700
==========================================
- Hits 48285 47663 -622
+ Misses 9057 8979 -78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4858
Variable type guessing implemented in #4838 changed the behavior in old workflows since output data have different variable types.
Description of changes
Made CSV file Import backward compatible. With these changes, widget behaves like before when opening old workflows and have new behavior on newer workflows.
Includes