Add function data.util.get_unique_names_domain #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4444 +/- ##
==========================================
- Coverage 87.46% 87.46% -0.01%
==========================================
Files 405 405
Lines 74132 73968 -164
==========================================
- Hits 64840 64693 -147
+ Misses 9292 9275 -17 |
|
This is basically a more elegant implementation of _domain_rename_duplicates from Merge data widget. I was thinking we should extract that one to utils and use it everywhere. When this is merged, I think we should change owmergedata.py accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Widgets that construct new domains (see #4382) may need this function to prepare unique names.
Includes