[FIX] MDS: Fix crashes when feeding column distances #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3583 +/- ##
==========================================
+ Coverage 83.97% 83.98% +<.01%
==========================================
Files 370 370
Lines 66976 67003 +27
==========================================
+ Hits 56246 56273 +27
Misses 10730 10730 |
janezd
approved these changes
Feb 9, 2019
There was a problem hiding this comment.
I can merge it as it is. But what do you think about also setting the label to "Labels" for distances? The user would almost always want this, it's easy to implement by overriding init_attr_values, and the base widget now has this safeguard against showing labels if there are too many.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3499 and #3328
Includes