OwTSNE: Don't catch errors during optimization #3580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlin-policar
force-pushed
the
tsne-dont-catch-optimization-errors
branch
2 times, most recently
from
79595ef to
6a78e75
Compare
Catching errors during optimization and showing them in the error message bar makes them difficult to report. Furthermore, no exceptions should be thrown during optimization and if something does go wrong, we need to fix it.
pavlin-policar
force-pushed
the
tsne-dont-catch-optimization-errors
branch
from
6a78e75 to
bcbe2b0
Compare
|
My best guess is that something was failing due to the way things were being mocked. This is superseded by #3604. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3548.
Catching errors during optimization and showing them in the error
message bar makes them difficult to report. Furthermore, no exceptions
should be thrown during optimization and if something does go wrong, we
need to fix it.
Description of changes
Remove the
optimization_error.Includes