[FIX] Fix asynchronous widget tests #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wait for results where needed * clanup after test
* wait for results/ready where needed * cleanup after test
ales-erjavec
force-pushed
the
fixes/async-tests
branch
from
f6e73b6 to
51f47e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2520 +/- ##
==========================================
+ Coverage 74.55% 74.62% +0.06%
==========================================
Files 320 320
Lines 56209 56225 +16
==========================================
+ Hits 41909 41959 +50
+ Misses 14300 14266 -34 |
markotoplak
reviewed
Aug 7, 2017
| @@ -215,31 +221,42 @@ def send_signal(self, input, value, *args, widget=None, wait=-1): | |||
| else: | |||
| raise ValueError("'{}' is not an input name for widget {}" | |||
| .format(input, type(widget).__name__)) | |||
| if widget.isBlocking(): | |||
There was a problem hiding this comment.
Of the widget is blocking the code will not get past this check and therefore the "wait" parameter is not used. Was this intended?
There was a problem hiding this comment.
Yes. The (existing) wait is done after the inputs are set and handleNewSignals is called. It is somewhat misplaced , but I do not want to change it.
astaric
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Asynchronous tests for owmds and owtestlearners set inputs to their respective widgets when they should not (a per
OWWidget.isBlocking).Description of changes
WidgetTest.send_signalif the target widget is not ready to receive inputs.waitparameter toWidgetTest.get_output.Includes