Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Show informative error when a tree cannot binarize #1925

Closed
wants to merge 2 commits into from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jan 14, 2017

Backport of #1837 (applied to the current master) to fix release 3.3.10.

Issue

Fixes #1835.
Allows error messages in multiple lines.

Description of changes

Overload check_data to check the number of values issue an error.

Includes
  • Code changes
  • Tests

@janezd janezd added this to the 3.3.10 milestone Jan 14, 2017
@janezd janezd force-pushed the bin-trees-for-3.3.10 branch from f4b5732 to d65fbe7 Compare January 14, 2017 16:01
@codecov-io
Copy link

codecov-io commented Jan 14, 2017

Current coverage is 88.98% (diff: 100%)

Merging #1925 into release-3.3.10 will not change coverage

@@           release-3.3.10      #1925   diff @@
================================================
  Files                  82         82          
  Lines                8973       8973          
  Methods                 0          0          
  Messages                0          0          
  Branches                0          0          
================================================
  Hits                 7985       7985          
  Misses                988        988          
  Partials                0          0          

Sunburst

Powered by Codecov. Last update 9108b3b...d65fbe7

@astaric
Copy link
Member

astaric commented Jan 18, 2017

Merged manually in 52fbaf5

@astaric astaric closed this Jan 18, 2017
@janezd janezd deleted the bin-trees-for-3.3.10 branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants