[FIX] owpca: Handle the case of 0 total variance in the PCA solution #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.25% (diff: 100%)@@ master #1897 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
* Check for 0 total variance in the pca solution and display a warning. * Prevent a NaN value to propagate into `self.variance_covered`. Fixes biolabgh-1896
`variance_covered` was persisted as a NaN value (biolabgh-1897), causing a TypeError in the widget's `__init__`.
ales-erjavec
force-pushed
the
fixes/pca-all-const-col
branch
from
5c14f84 to
ec907c7
Compare
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] owpca: Handle the case of 0 total variance in the PCA solution (cherry picked from commit ce7912e)
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] owpca: Handle the case of 0 total variance in the PCA solution (cherry picked from commit ce7912e)
astaric
added a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] owpca: Handle the case of 0 total variance in the PCA solution (cherry picked from commit ce7912e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-1896
Description of changes
self.variance_covered.Includes