OWFile: Set self.data to None on error #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.69% (diff: 100%)@@ master #1637 diff @@
==========================================
Files 78 78
Lines 8148 8148
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7227 7227
Misses 921 921
Partials 0 0
|
lanzagar
requested changes
Oct 7, 2016
janezd
force-pushed
the
owfile-setdata-none
branch
from
a7ee438 to
690daed
Compare
|
You're right. I added the missing |
lanzagar
approved these changes
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @lanzagar, #1635 no longer sets
self.datatoNonein case or error. Fixed.