[WIP][FIX] OWEditDomain: Fix crash when variable's attributes are represented as… #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.26% (diff: 100%)@@ master #1530 diff @@
==========================================
Files 77 77
Lines 7624 7624
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6729 6729
Misses 895 895
Partials 0 0
|
| @@ -51,13 +51,13 @@ def variable_description(var): | |||
| var_type.__name__, | |||
| var.name, | |||
| (("values", tuple(var.values)),), | |||
| tuple(sorted(var.attributes.items()))) | |||
| tuple((k, tuple(v)) for k, v in sorted(var.attributes.items()))) | |||
There was a problem hiding this comment.
What will happen if a variable has an attribute that has an int-value?
VesnaT
changed the title
VesnaT
force-pushed
the
fix_edit_domain
branch
from
c5acf01 to
e6636e3
Compare
|
EditDomain is not the only widget that crashes in this way. Perhaps it would be better if we decide that all Variable's values must be hashable and fix the coloring to use tuples, instead of fixing all other widgets. |
|
What Variable's values are those? Variable's attributes' keys? |
|
The tests from this PR have been cherry-picked to #1552, the rest was solved in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… lists
Fixes #1527