Merge pull request #3042 from ales-erjavec/fixes/vizrank-race-condition

[FIX] VizRank: Fix race condition in `toggle`
biolab · May 29, 2018 · 9caa6b7 · 9caa6b7
2 parents 42969bb + 12bdb21
commit 9caa6b7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/Orange/widgets/visualize/utils/__init__.py b/Orange/widgets/visualize/utils/__init__.py
@@ -352,6 +352,9 @@ def toggle(self):
         else:
             self.button.setText("Continue")
             self._thread.quit()
+            # Need to sync state (the worker must read the keep_running
+            # state and stop) for reliable restart.
+            self._thread.wait()
 
     def before_running(self):
         """Code that is run before running vizrank in its own thread"""