BoW: fix vectorisation to use only original weights for IDF on new data #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
|
|
PrimozGodec
force-pushed
the
fix-tfidf
branch
from
8f250b1 to
db0d3d3
Compare
PrimozGodec
force-pushed
the
fix-tfidf
branch
from
db0d3d3 to
134976d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bag of Words computed TF-IDF on new Corpus (from computing values) considering counts in new Corpus for IDF weighting. I think it should consider counts from the original Corpus for IDF. One document on the input resulted in different output than the same document in Corpus with others.
Description of changes
Use counts from the original Corpus for the IDF part.
Includes