Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix stopwords filtering #456

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[FIX] Fix stopwords filtering #456

merged 1 commit into from
Oct 1, 2019

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Sep 30, 2019 •
edited
Loading

Issue

Fixes #455

Description of changes
  • Stopwords are now correctly removed - I removed the whitespace on the end of each word in the dictionary
  • Languages in stopwords dropdown are now sorted in alphabetical order
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Sep 30, 2019 •
edited
Loading

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          34       34           
  Lines        1927     1927           
  Branches      328      329    +1     
=======================================
  Hits         1649     1649           
  Misses        238      238           
  Partials       40       40

@PrimozGodec
Copy link
Collaborator Author

Before merging this PR we should merge #457 - fixes tests.

@PrimozGodec PrimozGodec mentioned this pull request Oct 1, 2019
Closed
@lanzagar lanzagar changed the title [FIX] Fix stowords filtering [FIX] Fix stopwords filtering Oct 1, 2019
@ajdapretnar ajdapretnar merged commit 512f8eb into biolab:master Oct 1, 2019
@PrimozGodec PrimozGodec deleted the fix-stopwords branch October 1, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajdapretnar ajdapretnar Awaiting requested review from ajdapretnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preprocess text widget should remove stop-words
3 participants
@PrimozGodec @codecov-io @ajdapretnar