CorpusViewer: Break long urls #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lanzagar this quick and dirty fix works for me. |
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 34 34
Lines 1825 1825
Branches 333 333
=======================================
Hits 1552 1552
Misses 238 238
Partials 35 35 |
kernc
reviewed
Aug 29, 2017
| -moz-hyphens: auto; | ||
| -webkit-hyphens: auto; | ||
| hyphens: auto; | ||
| }} |
There was a problem hiding this comment.
This can be trimmed to three lines: overflow-wrap, word-wrap, word-break: break-all; hyphens.
|
Perhaps this is something we can update and merge? |
kernc
changed the title
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Long URLs cause the horizontal scroll bar in CorpusViewer.
Description of changes
Break more.
Includes