-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] The Guardian, Twitter, NYT: Error credentials #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 32 32
Lines 1603 1603
Branches 295 295
=======================================
Hits 1504 1504
Misses 60 60
Partials 39 39 |
@jerneju should we maybe fix This is fixing retrieving from CredentialManager. What about storing into it? Can the same thing happen there? |
@nikicc if we do not plan to show an error message in the future, then fixing |
@nikicc I have finally done the test. It does raise an error when trying to store it. |
This is probably blocked on biolab/orange3#2354 right? If so, we should probably bump the Orange version in requirements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests cannot run until the new version of Orange is out, since on Text we install Orange through pip. We should at least add something like:
@unittest.skipIf(LooseVersion(Orange.__version__) < LooseVersion('3.4.3'),
'Not supported in versions of Orange below 3.4.3')
or probably even better: move the test to the core Orange.
Closed in favor of biolab/orange3#2354 . |
Issue
Description of changes
try except block
Includes