Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus dictionary - Postpone its removal #1004

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Dictionary deprecation was planned in version 1.15, and total removal was planned for version 1.16. Since #990 was merged after 1.15, it is not valid anymore.

Description of changes

Since deprecation will be introduced in 1.16, the dictionary removal is postponed to version 1.17

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

Codecov Report

Merging #1004 (3cbb752) into master (4da0aab) will increase coverage by 0.02%.
Report is 7 commits behind head on master.
The diff coverage is 89.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   80.53%   80.56%   +0.02%     
==========================================
  Files          93       93              
  Lines       12274    12270       -4     
  Branches     1660     1661       +1     
==========================================
  Hits         9885     9885              
+ Misses       2092     2090       -2     
+ Partials      297      295       -2     

@PrimozGodec PrimozGodec merged commit 5688730 into biolab:master Aug 25, 2023
@PrimozGodec PrimozGodec deleted the postphone-dict-removal branch August 25, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants