[ENH] Polynomial Regression: Allow fixing the intercept to 0 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
changed the title
janezd
commented
Aug 27, 2020
| @@ -324,13 +373,6 @@ def apply(self): | |||
| self.Outputs.model.send(predictor) | |||
|
|
|||
| # Send model coefficents | |||
| model = None | |||
| if predictor is not None: | |||
There was a problem hiding this comment.
This code is moved to an earlier place and the check is changed to if hasattr(predictor, "model"), which covers both None and RegressTo0 (which is new in this code). A bit later, the code expects that predictor is not None. I have not changed this, so if it was broken before, it still is (though we used this widget a lot and no student ever complained).
PrimozGodec
force-pushed
the
polyreg-fit-intercept
branch
from
5016213 to
417533a
Compare
janezd
force-pushed
the
polyreg-fit-intercept
branch
from
417533a to
567bbff
Compare
janezd
changed the title
janezd
force-pushed
the
polyreg-fit-intercept
branch
from
567bbff to
412dbf0
Compare
janezd
force-pushed
the
polyreg-fit-intercept
branch
from
412dbf0 to
8ba0dc2
Compare
…fferent. This prevents crash due to same name on output.
janezd
force-pushed
the
polyreg-fit-intercept
branch
from
8ba0dc2 to
0b0814a
Compare
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 87.65% 86.93% -0.73%
==========================================
Files 20 20
Lines 2893 2932 +39
Branches 351 363 +12
==========================================
+ Hits 2536 2549 +13
- Misses 325 342 +17
- Partials 32 41 +9
Continue to review full report at Codecov.
|
janezd
force-pushed
the
polyreg-fit-intercept
branch
from
6c1bd69 to
46caeb5
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #93 and shows some great love for this venerable old widget.
Requires biolab/orange3#4958, commit biolab/orange3@cb5a551.Description of changes
See commit messages.
Includes