Remove highcharts #114
Merged
Remove highcharts #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
remove-highcharts
branch
from
11a176f to
8677930
Compare
|
Now when we removed the Highcharts we can also change the license of this add-on (I think the current CC was set because we used HighCharts). @janezd do you know anything about licenses? We have different licenses for addons and Orange. I think GPL is the most common for addons. |
janezd
force-pushed
the
remove-highcharts
branch
from
8677930 to
86b06af
Compare
|
I think you're right: we switched to Creative Commons because of (or at least at the same time as when we added) highcharts. GPL would be more appropriate, also because of PyQt --- I'm not sure whether and how this goes together. I changed the license. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#111, #112 and #113 removed dependencies on highcharts. This PR removes it from distribution.
Requires #112 and #113.