Merge pull request #55 from janezd/pytablemodel-wrap-empty

PyTableModel: Fix wrapping empty lists in constructor
biolab · Apr 10, 2020 · c0a40f0 · c0a40f0
2 parents 0ea72bc + e628027
commit c0a40f0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/orangewidget/utils/itemmodels.py b/orangewidget/utils/itemmodels.py
@@ -255,7 +255,9 @@ def __init__(self, sequence=None, parent=None, editable=False):
         self._editable = editable
         self._table = None
         self._roleData = None
-        self.wrap(sequence or [])
+        if sequence is None:
+            sequence = []
+        self.wrap(sequence)
 
     def rowCount(self, parent=QModelIndex()):
         return 0 if parent.isValid() else len(self)

diff --git a/orangewidget/utils/tests/test_itemmodels.py b/orangewidget/utils/tests/test_itemmodels.py
@@ -98,6 +98,14 @@ def test_wrap(self):
         self.assertEqual(self.model.rowCount(), 1)
         self.assertEqual(self.model.columnCount(), 1)
 
+    def test_init_wrap_empty(self):
+        # pylint: disable=protected-access
+        t = []
+        model = PyTableModel(t)
+        self.assertIs(model._table, t)
+        t.append([1, 2, 3])
+        self.assertEqual(list(model), [[1, 2, 3]])
+
     def test_clear(self):
         self.model.clear()
         self.assertEqual(self.model.rowCount(), 0)