Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code refactoring #273

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dal-aayush
Copy link

  • RES-XXXX
  • Blocking PRs: ADD HERE IF ANY
  • People
    • Reviewers (>=1): ADD HERE
    • Merger (>=1): ADD HERE
    • FYI: ADD HERE IF ANY
  • Release note (if needed)
  • No code copied from outside Bina
  • Tests (Unit, Workflow, ITL & Gherkin) are passing
  • PR labels, milestones & assignees

Summary

Briefly describe the changes and reasons for the changes.

Has done minor code refactoring. Here is the list of applied code refactoring with file
Introduce Explaining variable
src/main/java/com/bina/varsim/fastqLiftover/readers/DWGSIMPairedFastqReader.java

Decompose Conditional
src/main/java/com/bina/varsim/tools/simulation/RandDGV2VCF.java

Extract Method
src/main/java/com/bina/varsim/tools/simulation/RandBED2VCF.java

Extract Class
Replace conditional with Polymorphism
src/main/java/com/bina/varsim/fastqLiftover/readers/ARTFastqAlnReader.java

Move methods
src/main/java/com/bina/varsim/types/constraint/ConstraintRecord.java
src/main/java/com/bina/varsim/types/constraint/Constraint.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants