Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Windows compatibility #1

wants to merge 7 commits into from

Conversation

AliKhoda
Copy link

Hi,

First efforts to make bob work on windows.

Thanks,
AKh

@183amir
Copy link
Contributor

183amir commented Jan 28, 2018

Hi Ali,

Instead of modifying all these places, you can just add this in construct_search_paths in utils.py to take CONDA_PREFIX\Library into account on Windoze.

@AliKhoda
Copy link
Author

Hi,

Thanks for the guidance. Changes are modified accordingly.

if os.name == 'nt':
binpaths += [os.path.join('mingw-w64','bin')]
name = name + '.exe'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to remove this too. We are trying to add support for msvc not mingw 64 which are incompatible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think incompatibility applies to executables. Many executables are compiled on MingW and can be used by passing input arguments regardless of how they are compiled. Removing this will cause problems in the future, if not now. The "name = name + '.exe'" is also required as in windows executables need the extension in special cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants