-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows compatibility #1
base: master
Are you sure you want to change the base?
Conversation
Hi Ali, Instead of modifying all these places, you can just add this in |
Hi, Thanks for the guidance. Changes are modified accordingly. |
if os.name == 'nt': | ||
binpaths += [os.path.join('mingw-w64','bin')] | ||
name = name + '.exe' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to remove this too. We are trying to add support for msvc not mingw 64 which are incompatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think incompatibility applies to executables. Many executables are compiled on MingW and can be used by passing input arguments regardless of how they are compiled. Removing this will cause problems in the future, if not now. The "name = name + '.exe'" is also required as in windows executables need the extension in special cases.
Hi,
First efforts to make bob work on windows.
Thanks,
AKh