Remove toredis #15
Open
Remove toredis #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests using nosetests and ipython. Ipython imports the caller file internally, so if it is not importable, it sillently fails and is terrible to debug
|
@josenavas, tests are failing btw |
| @@ -0,0 +1,26 @@ | |||
| language: python | |||
There was a problem hiding this comment.
Awesome... thank you for getting travis up
|
I'm concerned about the potential for a race condition. If two processes issue a publish during the sample 1ms window, then it looks like one of the messages will go unanswered. It might be possible to address this with a handler instead of a periodic callback, however it is still possible for multiple messages to happen while the handler is being executed. It is possible redis already mitigates these scenarios though |
|
@josenavas, just going back through PRs given the call earlier today. Status on this? |
|
tornadis library may be a good replacement for toredis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the toredis dependency, adds support for python 3 and adds automatic testing.