Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lamps v1.0.3 #52005

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions recipes/lamps/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{% set name = "lamps" %}
{% set version = "1.0.3" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/lamps-{{ version }}.tar.gz
sha256: c85de92edcb4cd450aeebcb829729f163a02b3905146ef5208f911f38f2abe63

build:
entry_points:
- lamp = lamp.__main__:main
noarch: python
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0

requirements:
host:
- python >=3.8
- setuptools >=61.0
- wheel
- pip
run:
- python >=3.8
- numpy
- scipy
- pandas
- pyside6
- pyteomics
- openpyxl
- pyjanitor
Comment on lines +19 to +33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding PySide6 specific build requirements.

Since PySide6 is a Qt binding, it might need additional build dependencies in the Conda environment.

Consider adding the following to the host section:

  host:
    - python >=3.8
    - setuptools >=61.0
    - wheel
    - pip
+   - qt-main
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
requirements:
host:
- python >=3.8
- setuptools >=61.0
- wheel
- pip
run:
- python >=3.8
- numpy
- scipy
- pandas
- pyside6
- pyteomics
- openpyxl
- pyjanitor
requirements:
host:
- python >=3.8
- setuptools >=61.0
- wheel
- pip
- qt-main
run:
- python >=3.8
- numpy
- scipy
- pandas
- pyside6
- pyteomics
- openpyxl
- pyjanitor


test:
imports:
- lamp
commands:
- pip check
- lamp --help
requires:
- pip

about:
home: https://pypi.org/project/lamps/
summary: Liverpool Annotation of metabolites using Mass Spectrometry
dev_url: https://github.com/wanchanglin/lamp
license: GPL-3.0
martin-g marked this conversation as resolved.
Show resolved Hide resolved
license_file: LICENSE

extra:
recipe-maintainers:
- harryln-1