Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: require python>=3.10 #24

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: require python>=3.10 #24

wants to merge 3 commits into from

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson mentioned this pull request Jun 4, 2024
Merged
ahwagner
ahwagner reviewed Aug 26, 2024
View reviewed changes
pyproject.toml
@@ -21,6 +21,7 @@ dependencies = [
"coloredlogs",
"connexion[swagger-ui] ~= 2.2",
"Flask ~= 2.2",
"setuptools", # pin until yoyo-migrations is updated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "pin until..." but does not include a pinned version?

ahwagner
ahwagner reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@ahwagner ahwagner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, above.

In general, seems like good practice. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @ahwagner