Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: format with Ruff #180

Merged
merged 3 commits into from
Jun 21, 2024
Merged

style: format with Ruff #180

merged 3 commits into from
Jun 21, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Jun 5, 2024

Adds ruff formatting.

eutils didn't have some of the other biocommons QC stuff (github actions, precommit) so adds a minimal version of each as well.

@jsstevenson jsstevenson marked this pull request as ready for review June 18, 2024 11:57
@jsstevenson jsstevenson requested a review from a team as a code owner June 18, 2024 11:57
pyproject.toml Outdated
@@ -93,3 +94,7 @@ markers = [
"network: tests that require network connectivity",
"slow: slow tests that should be run infrequently",
]

[tool.ruff]
src = ["src", "test"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src = ["src", "test"]
src = ["src", "tests"]

on:
push:
tags:
- '[0-9]+.[0-9]+.[0-9]+'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but wanted to comment that this line is not in bioutils repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have already said this somewhere else (thought i had) but in general, everything is pretty out of sync w/ the template. Not sure if that's something we want to tackle iteratively or do a single "clean sweep"/reset at some point.

@jsstevenson jsstevenson requested a review from korikuzma June 21, 2024 12:54
@jsstevenson jsstevenson merged commit a9a1923 into main Jun 21, 2024
4 checks passed
@jsstevenson jsstevenson deleted the ruff-format branch June 21, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants