Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart WIP #183

Closed
wants to merge 8 commits into from
Closed

Helm Chart WIP #183

wants to merge 8 commits into from

Conversation

netflash
Copy link
Contributor

This ultimately should address #154.
not sure this is ready to merge. Expecting some feedback to improve it. /cc @bilalaslamseattle

@binaryberry
Copy link
Owner

Thanks @netflash for the contribution! Is there a reason why you'd like to include the helm charts with the app itself? Normally it's something that would be separate and live with the other charts.

@netflash
Copy link
Contributor Author

@binaryberry TBH I don't have an answer. All the charts I create for personal use - I store them together with apps. Perhaps because I have never had enough time to understand how helm repository works.

@netflash
Copy link
Contributor Author

Any advice would be highly appreciated. What should I do with this ?

@binaryberry
Copy link
Owner

Hi @netflash, sorry about the late reply! Speaking to some of my ops colleagues, it seems it's unusual adding helm charts with the app itself, and that the convention is to keep them separate. So I'm going to close this PR. Thanks for suggesting though!

@binaryberry binaryberry closed this Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants