GH #122: Enable CountryRules by default #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graue
reviewed
May 27, 2024
No, they don't. I thought it would make the code slimmer but you're right, we do want to stay parallel to GH as much as possible. I reverted those changes. |
graue
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Seems fine. Do you plan to pursue this part of #122 as well?
correct operation requires country rules and they should not be disabled by default, nor should the feature to disable them exist. Ideally we would merge this change into upstream (which is also currently failing to handle cycleway:left and cycleway:right at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.