WIP make /route-rt use CH for bike-only route #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it gets the data but the CH route doesnt include the 'legs', im not sure why. This breaks the UI.
makes sense, you only need legs for a multi-leg trip on transit. the bike only route would only ever have one leg so no point making a separate object |
|
okay, well the legs are returned for the our current zero transfer route and the UI hard crashes if they are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it gets the data but the CH route doesnt include the 'legs', im not sure why. This breaks the UI.
i'm stepping away from this because it isn't a priority for me right now and it is turning into a bigger time sink thank expected.